Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revision kind to RevisionInfo #135

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

timwangmusic
Copy link
Contributor

The kind field is missing in RevisionInfo. The field is important because users can use this info for a general description of what are changed in the revision.

changes.go Outdated Show resolved Hide resolved
Copy link
Owner

@andygrunwald andygrunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@andygrunwald
Copy link
Owner

Thanks a lot, @timwangmusic. Also, thanks for your review @chaodaiG, much appreciated.

@andygrunwald andygrunwald merged commit 9ea5350 into andygrunwald:master Feb 8, 2023
@timwangmusic timwangmusic deleted the add-revision-kind branch February 9, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants